netdev - RE: [PATCH net-next 3/3] net: airoha: Introduce ethernet support for EN7581 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <BY3PR18MB473784C748E054DFED063C19C6FF2@BY3PR18MB4737.namprd18.prod.outlook.com>
Date: Mon, 3 Jun 2024 09:04:48 +0000
From: Sunil Kovvuri Goutham <sgoutham@...vell.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nbd@....name"
	<nbd@....name>,
        "lorenzo.bianconi83@...il.com"
	<lorenzo.bianconi83@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "conor@...nel.org" <conor@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "robh+dt@...nel.org"
	<robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org"
	<conor+dt@...nel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "catalin.marinas@....com"
	<catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "upstream@...oha.com" <upstream@...oha.com>,
        "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>,
        "benjamin.larsson@...exis.eu"
	<benjamin.larsson@...exis.eu>
Subject: RE: [PATCH net-next 3/3] net: airoha: Introduce ethernet support for
 EN7581 SoC



>-----Original Message-----
>From: Lorenzo Bianconi <lorenzo@...nel.org>
>Sent: Monday, June 3, 2024 1:24 PM
>To: Sunil Kovvuri Goutham <sgoutham@...vell.com>
>Cc: netdev@...r.kernel.org; nbd@....name; lorenzo.bianconi83@...il.com;
>davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
>pabeni@...hat.com; conor@...nel.org; linux-arm-kernel@...ts.infradead.org;
>robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
>devicetree@...r.kernel.org; catalin.marinas@....com; will@...nel.org;
>upstream@...oha.com; angelogioacchino.delregno@...labora.com;
>benjamin.larsson@...exis.eu
>Subject: Re: [EXTERNAL] [PATCH net-next 3/3] net: airoha: Introduce ethernet
>support for EN7581 SoC
>
>> >+
>> >+	q = &eth->q_tx[qid];
>> >+	spin_lock_bh(&q->lock);
>>
>> Same here, is this lock needed ?
>> If yes, can you please elaborate why.
>
>ndo_start_xmit callback can run in parallel with airoha_qdma_tx_napi_poll()
>

Okay.

>>
>> >+
>> >+	if (q->queued + nr_frags > q->ndesc) {
>> >+		/* not enough space in the queue */
>> >+		spin_unlock_bh(&q->lock);
>> >+		return NETDEV_TX_BUSY;
>> >+	}
>> >+
>>
>> I do not see netif_set_tso_max_segs() being set, so HW doesn't have
>> any limit wrt number of TSO segs and number of fragments in skb, is it ??
>
>I do not think there is any specific limitation for it
>

Okay.

>>
>> ...........
>> >+static int airoha_probe(struct platform_device *pdev) {
>> >+	struct device_node *np = pdev->dev.of_node;
>> >+	struct net_device *dev;
>> >+	struct airoha_eth *eth;
>> >+	int err;
>> >+
>> >+	dev = devm_alloc_etherdev_mqs(&pdev->dev, sizeof(*eth),
>> >+				      AIROHA_NUM_TX_RING,
>> >AIROHA_NUM_RX_RING);
>>
>> Always 32 queues, even if kernel is booted with less number cores ?
>
>ethtool is not supported yet, I will add it with followup patches
>

I meant by default.
Wouldn't it better to check online cpu count ?
If system is booted with just 10 cores, then why initialize 32 cores is my point.

Thanks,
Sunil.