netdev - RE: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline ipsec transmit offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <SN7PR18MB5314C837EBC54B24350DC638E3FF2@SN7PR18MB5314.namprd18.prod.outlook.com>
Date: Mon, 3 Jun 2024 09:06:13 +0000
From: Bharat Bhushan <bbhushan2@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam
	<hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        Jerin Jacob
	<jerinj@...vell.com>, Linu Cherian <lcherian@...vell.com>,
        "richardcochran@...il.com" <richardcochran@...il.com>
Subject: RE: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
 ipsec transmit offload



> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Saturday, June 1, 2024 3:50 PM
> To: Bharat Bhushan <bbhushan2@...vell.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@...vell.com>; Geethasowjanya Akula
> <gakula@...vell.com>; Subbaraya Sundeep Bhatta <sbhatta@...vell.com>;
> Hariprasad Kelam <hkelam@...vell.com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; Jerin Jacob
> <jerinj@...vell.com>; Linu Cherian <lcherian@...vell.com>;
> richardcochran@...il.com
> Subject: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline ipsec
> transmit offload
> 
> 
> ----------------------------------------------------------------------
> On Tue, May 28, 2024 at 07:23:47PM +0530, Bharat Bhushan wrote:
> > Prepare and submit crypto hardware (CPT) instruction for outbound
> > inline ipsec crypto mode offload. The CPT instruction have
> > authentication offset, IV offset and encapsulation offset in input
> > packet. Also provide SA context pointer which have details about algo,
> > keys, salt etc. Crypto hardware encrypt, authenticate and provide the
> > ESP packet to networking hardware.
> >
> > Signed-off-by: Bharat Bhushan <bbhushan2@...vell.com>
> 
> Hi Bharat,
> 
> A minor nit from my side as it looks like there will be a v4 anyway.
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> 
> ...
> 
> > +bool cn10k_ipsec_transmit(struct otx2_nic *pf, struct netdev_queue *txq,
> > +			  struct otx2_snd_queue *sq, struct sk_buff *skb,
> > +			  int num_segs, int size)
> > +{
> 
> ...
> 
> > +	/* Check for valid SA context */
> > +	sa_info = (struct cpt_ctx_info_s *)x->xso.offload_handle;
> > +	if (!sa_info || !sa_info->sa_iova) {
> > +		netdev_err(pf->netdev, "Invalid SA conext\n");
> 
> nit: context
> 
>      checkpatch.pl --codespell is your friend.

Will fix here and run this on all patches.

Thanks
-Bharat

> 
> > +		goto drop;
> > +	}
> 
> ...