netdev - Re: [PATCH net-next] net: ethernet: ti: Makefile: Add icssg_queues.o in TI_ICSSG_PRUETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 11:20:17 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: MD Danish Anwar <danishanwar@...com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Diogo Ivo <diogo.ivo@...mens.com>, Andrew Lunn <andrew@...n.ch>,
 Roger Quadros <rogerq@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 "David S. Miller" <davem@...emloft.net>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, srk@...com,
 Vignesh Raghavendra <vigneshr@...com>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next] net: ethernet: ti: Makefile: Add icssg_queues.o
 in TI_ICSSG_PRUETH_SR1

On 05.06.24 05:56, MD Danish Anwar wrote:
> icssg_config.c uses some APIs that are defined in icssg_queue.c.
> TI_ICSSG_PRUETH_SR1 uses icssg_config.o but not icssg_queues.o as a
> result the below build error is seen
> 
> ERROR: modpost: "icssg_queue_pop"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> ERROR: modpost: "icssg_queue_push"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> 
> Fix this by adding icssg_queues.o in TI_ICSSG_PRUETH_SR1
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202405182038.ncf1mL7Z-lkp@intel.com/
> Fixes: 487f7323f39a ("net: ti: icssg-prueth: Add helper functions to configure FDB")
> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---
> Cc: Thorsten Leemhuis <linux@...mhuis.info>

Thx, seems this did the trick (tested this patch with today's -next and
assuming here that no change fixed it in between).

Reported-and-tested-by: Thorsten Leemhuis <linux@...mhuis.info>
Closes:
https://lore.kernel.org/all/de980a49-b802-417a-a57e-2c47f67b08e4@leemhuis.info/

Ciao, Thorsten