netdev - Re: [PATCH net-next] net: ethernet: ti: Makefile: Add icssg_queues.o in TI_ICSSG_PRUETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <28803aee-e3fe-4e9d-8410-4ac957d77dd6@lunn.ch>
Date: Wed, 5 Jun 2024 14:27:33 +0200
From: Andrew Lunn <andrew@...n.ch>
To: MD Danish Anwar <danishanwar@...com>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Diogo Ivo <diogo.ivo@...mens.com>,
	Roger Quadros <rogerq@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org, srk@...com,
	Vignesh Raghavendra <vigneshr@...com>,
	kernel test robot <lkp@...el.com>,
	Thorsten Leemhuis <linux@...mhuis.info>
Subject: Re: [PATCH net-next] net: ethernet: ti: Makefile: Add icssg_queues.o
 in TI_ICSSG_PRUETH_SR1

On Wed, Jun 05, 2024 at 09:26:17AM +0530, MD Danish Anwar wrote:
> icssg_config.c uses some APIs that are defined in icssg_queue.c.
> TI_ICSSG_PRUETH_SR1 uses icssg_config.o but not icssg_queues.o as a
> result the below build error is seen
> 
> ERROR: modpost: "icssg_queue_pop"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> ERROR: modpost: "icssg_queue_push"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> 
> Fix this by adding icssg_queues.o in TI_ICSSG_PRUETH_SR1

Please take a look at
https://patchwork.kernel.org/project/netdevbpf/patch/20240528161603.2443125-1-arnd@kernel.org/


    Andrew

---
pw-bot: cr