netdev - Re: [Intel-wired-lan] [PATCH iwl-next v1 5/5] ice: refactor to use helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c19f080-8ad2-4e9a-b664-b5e3e45a852a@intel.com>
Date: Wed, 5 Jun 2024 06:01:03 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>, <netdev@...r.kernel.org>,
	<intel-wired-lan@...ts.osuosl.org>
CC: Jacob Keller <jacob.e.keller@...el.com>, <linux-doc@...r.kernel.org>,
	<corbet@....net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 5/5] ice: refactor to use
 helpers

On 6/5/24 00:13, Jesse Brandeburg wrote:
> Use the ice_netdev_to_pf() helper in more places and remove a bunch of
> boilerplate code. Not every instance could be replaced due to use of the
> netdev_priv() output or the vsi variable within a bunch of functions.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_ethtool.c  | 42 ++++++-------------
>   .../net/ethernet/intel/ice/ice_flex_pipe.c    |  8 +---
>   drivers/net/ethernet/intel/ice/ice_lag.c      |  5 +--
>   drivers/net/ethernet/intel/ice/ice_main.c     |  7 +---
>   drivers/net/ethernet/intel/ice/ice_sriov.c    |  3 +-
>   5 files changed, 19 insertions(+), 46 deletions(-)
> 

very nice, thanks
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>