netdev - Re: [PATCH net] net: ethtool: fix the error condition in ethtool_get_phy_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 06:05:07 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Su Hui <suhui@...china.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <nathan@...nel.org>,
	<ndesaulniers@...gle.com>, <morbo@...gle.com>, <justinstitt@...gle.com>
CC: <andrew@...n.ch>, <ahmed.zaki@...el.com>, <hkallweit1@...il.com>,
	<justin.chen@...adcom.com>, <jdamato@...tly.com>,
	<gerhard@...leder-embedded.com>, <d-tatianin@...dex-team.ru>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<llvm@...ts.linux.dev>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net] net: ethtool: fix the error condition in
 ethtool_get_phy_stats_ethtool()

On 6/5/24 05:47, Su Hui wrote:
> Clang static checker (scan-build) warning:
> net/ethtool/ioctl.c:line 2233, column 2
> Called function pointer is null (null dereference).
> 
> Return '-EOPNOTSUPP' when 'ops->get_ethtool_phy_stats' is NULL to fix
> this typo error.
> 
> Fixes: 201ed315f967 ("net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers")
> Signed-off-by: Su Hui <suhui@...china.com>
> ---
>   net/ethtool/ioctl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
> index 5a55270aa86e..e645d751a5e8 100644
> --- a/net/ethtool/ioctl.c
> +++ b/net/ethtool/ioctl.c
> @@ -2220,7 +2220,7 @@ static int ethtool_get_phy_stats_ethtool(struct net_device *dev,
>   	const struct ethtool_ops *ops = dev->ethtool_ops;
>   	int n_stats, ret;
>   
> -	if (!ops || !ops->get_sset_count || ops->get_ethtool_phy_stats)
> +	if (!ops || !ops->get_sset_count || !ops->get_ethtool_phy_stats)
>   		return -EOPNOTSUPP;
>   
>   	n_stats = ops->get_sset_count(dev, ETH_SS_PHY_STATS);

Thank you,
both the change and provided Fixes tag are correct.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>