[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240610.154850.1916370094900982618.fujita.tomonori@gmail.com>
Date: Mon, 10 Jun 2024 15:48:50 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: hfdevel@....net
Cc: fujita.tomonori@...il.com, andrew@...n.ch, horms@...nel.org,
kuba@...nel.org, jiri@...nulli.us, pabeni@...hat.com,
linux@...linux.org.uk, naveenm@...vell.com, jdamato@...tly.com,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next v9 3/6] net: tn40xx: add basic Tx handling
On Sun, 9 Jun 2024 13:41:20 +0200
Hans-Frieder Vogt <hfdevel@....net> wrote:
>> +static int tn40_priv_init(struct tn40_priv *priv)
>> +{
>> + int ret;
>> +
>> + tn40_set_link_speed(priv, 0);
>> +
>> + ret = tn40_hw_reset(priv);
>> + if (ret)
>> + return ret;
>> +
>> + /* Set GPIO[9:0] to output 0 */
>> + tn40_write_reg(priv, 0x51E0, 0x30010006); /* GPIO_OE_ WR CMD */
>> + tn40_write_reg(priv, 0x51F0, 0x0); /* GPIO_OE_ DATA */
>> + tn40_write_reg(priv, TN40_REG_MDIO_CMD_STAT, 0x3ec8);
>
> the last tn40_write_reg (to TN40_REG_MDIO_CMD_STAT) is in fact the
> same as:
>
> tn40_mdio_set_speed(priv, TN40_MDIO_SPEED_1MHZ);
This means that as the original driver does, this driver sets bus
speed to 6MHZ for QT2025 PHY, however after that, this driver sets
it to 1MHZ again?
Powered by blists - more mailing lists