netdev - Re: [PATCH net-next v9 5/6] net: tn40xx: add mdio bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240610.163540.1951943035923637886.fujita.tomonori@gmail.com>
Date: Mon, 10 Jun 2024 16:35:40 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: hfdevel@....net
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, andrew@...n.ch,
 horms@...nel.org, kuba@...nel.org, jiri@...nulli.us, pabeni@...hat.com,
 linux@...linux.org.uk, naveenm@...vell.com, jdamato@...tly.com
Subject: Re: [PATCH net-next v9 5/6] net: tn40xx: add mdio bus support

On Sun, 9 Jun 2024 13:22:56 +0200
Hans-Frieder Vogt <hfdevel@....net> wrote:

> On 06.06.2024 01.26, FUJITA Tomonori wrote:
>> +
>> +static void tn40_mdio_set_speed(struct tn40_priv *priv, u32 speed)
>> +{
>> +	void __iomem *regs = priv->regs;
>> +	int mdio_cfg;
>> +
>> +	mdio_cfg = readl(regs + TN40_REG_MDIO_CMD_STAT);
> the result of the readl is nowhere used. And as far as I have seen it
> is
> not needed to trigger anything. Therefore I suggest you delete this
> read
> operation.

I thought that reading the register has some effect but seems the
hardware works without the above line. I'll drop it in v10.


>> +	if (speed == 1)
> why not use the defined value TN40_MDIO_SPEED_1MHZ here? It would make
> the logic of the function even clearer.

Yeah. I left the original code alone. I'll fix in v10.

Thanks!