lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZmbEbIQY+6c/qadI@shell.armlinux.org.uk>
Date: Mon, 10 Jun 2024 10:16:28 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Andrew Halaney <ahalaney@...hat.com>
Cc: Serge Semin <fancer.lancer@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH RFC net-next v2 1/8] net: stmmac: add infrastructure for
 hwifs to provide PCS

On Wed, Jun 05, 2024 at 02:57:34PM -0500, Andrew Halaney wrote:
> On Fri, May 31, 2024 at 12:26:15PM GMT, Russell King (Oracle) wrote:
> > @@ -310,6 +315,9 @@ struct stmmac_ops {
> >  	void (*core_init)(struct mac_device_info *hw, struct net_device *dev);
> >  	/* Update MAC capabilities */
> >  	void (*update_caps)(struct stmmac_priv *priv);
> > +	/* Get phylink PCS (for MAC */
> 
> nit: unclosed parenthesis

Please learn to trim your review replies so your patch submitters don't
have to waste time scroll through lots of useless context. This has
been part of good netiquette for decades. Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ