[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZmbFK2SYyHcqzSeK@shell.armlinux.org.uk>
Date: Mon, 10 Jun 2024 10:19:39 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Andrew Halaney <ahalaney@...hat.com>
Cc: Serge Semin <fancer.lancer@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH RFC net-next v2 3/8] net: stmmac: dwmac1000: convert
sgmii/rgmii "pcs" to phylink
On Wed, Jun 05, 2024 at 03:05:43PM -0500, Andrew Halaney wrote:
> On Fri, May 31, 2024 at 12:26:25PM GMT, Russell King (Oracle) wrote:
> > @@ -335,8 +303,12 @@ static int dwmac1000_irq_status(struct mac_device_info *hw,
> >
> > dwmac_pcs_isr(ioaddr, GMAC_PCS_BASE, intr_status, x);
> >
> > - if (intr_status & PCS_RGSMIIIS_IRQ)
> > - dwmac1000_rgsmii(ioaddr, x);
> > + if (intr_status & PCS_RGSMIIIS_IRQ) {
> > + /* TODO Dummy-read to clear the IRQ status */
> > + readl(ioaddr + GMAC_RGSMIIIS);
>
> This seems to me that you're doing the TODO here? Maybe I'm
> misunderstanding... maybe not :)
Please trim your replies.
These two lines come from Serge - please ask him why it's marked as a
TODO. I assume he has a reason. Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists