netdev - Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fa9fadc-a89d-467a-aae9-c65469ff5fe1@lunn.ch>
Date: Wed, 12 Jun 2024 21:16:13 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Csókás, Bence <csokas.bence@...lan.hu>
Cc: Frank Li <Frank.Li@...escale.com>,
	"David S. Miller" <davem@...emloft.net>, imx@...ts.linux.dev,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Richard Cochran <richardcochran@...il.com>,
	Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
	Clark Wang <xiaoning.wang@....com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared on
 link-down

On Tue, Jun 11, 2024 at 10:04:05AM +0200, Csókás, Bence wrote:
> FEC_ECR_EN1588 bit gets cleared after MAC reset in `fec_stop()`, which
> makes all 1588 functionality shut down, and all the extended registers
> disappear, on link-down, making the adapter fall back to compatibility
> "dumb mode". However, some functionality needs to be retained (e.g. PPS)
> even without link.
> 
> Fixes: 6605b730c061 ("FEC: Add time stamping code and a PTP hardware clock")
> Cc: Richard Cochran <richardcochran@...il.com>
> 
> Signed-off-by: Csókás, Bence <csokas.bence@...lan.hu>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew