netdev - Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jun 2024 08:12:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Csókás, Bence" <csokas.bence@...lan.hu>
Cc: Frank Li <Frank.Li@...escale.com>, "David S. Miller"
 <davem@...emloft.net>, <imx@...ts.linux.dev>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Richard Cochran"
 <richardcochran@...il.com>, Wei Fang <wei.fang@....com>, Shenwei Wang
 <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared
 on link-down

On Tue, 11 Jun 2024 10:04:05 +0200 Csókás, Bence wrote:
> +	if (fep->bufdesc_ex) {
> +		val = readl(fep->hwp + FEC_ECNTRL);
> +		val |= FEC_ECR_EN1588;
> +		writel(val, fep->hwp + FEC_ECNTRL);

FEC_ECNTRL gets written multiple times in this function,
including with 0, and then you RMW it to add this flag.

Is this intentional? It really seems like you should be
adding this flag more consistently or making sure its
not cleared, rather than appending "add it back" at the 
end of the function...
-- 
pw-bot: cr