netdev - Re: [PATCH net-next v2 3/5] gve: Add flow steering device option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240614192209.7c69df0b@kernel.org>
Date: Fri, 14 Jun 2024 19:22:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ziwei Xiao <ziweixiao@...gle.com>
Cc: netdev@...r.kernel.org, jeroendb@...gle.com, pkaligineedi@...gle.com,
 shailend@...gle.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, willemb@...gle.com, hramamurthy@...gle.com,
 rushilg@...gle.com, horms@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/5] gve: Add flow steering device option

On Thu, 13 Jun 2024 01:47:42 +0000 Ziwei Xiao wrote:
> +	if (dev_op_flow_steering &&
> +	    (supported_features_mask & GVE_SUP_FLOW_STEERING_MASK)) {
> +		if (dev_op_flow_steering->max_flow_rules) {
> +			priv->max_flow_rules =
> +				be32_to_cpu(dev_op_flow_steering->max_flow_rules);
> +			dev_info(&priv->pdev->dev,
> +				 "FLOW STEERING device option enabled with max rule limit of %u.\n",
> +				 priv->max_flow_rules);

There's a print to the kernel logs every time driver loads to tell 
the user flow steering is available...

> -	/* DQO supports LRO. */
>  	if (!gve_is_gqi(priv))
> -		priv->dev->hw_features |= NETIF_F_LRO;
> +		priv->dev->hw_features |= NETIF_F_LRO | NETIF_F_NTUPLE;

Yet the uAPI feature which is supposed to let the user know its
supported appears to be set unconditionally.