netdev - Re: [PATCH net-next v2 5/5] gve: Add flow steering ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240614192721.02700256@kernel.org>
Date: Fri, 14 Jun 2024 19:27:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ziwei Xiao <ziweixiao@...gle.com>
Cc: netdev@...r.kernel.org, jeroendb@...gle.com, pkaligineedi@...gle.com,
 shailend@...gle.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, willemb@...gle.com, hramamurthy@...gle.com,
 rushilg@...gle.com, horms@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/5] gve: Add flow steering ethtool support

On Thu, 13 Jun 2024 01:47:44 +0000 Ziwei Xiao wrote:
> +	dev_hold(netdev);
> +	rtnl_unlock();

If you care about the op being unlocked make the core not take
the lock in the first place. The core itself doesn't need it
either. Add a flag in the ops to tell the core driver doesn't
need the lock.

Disappointing :|