netdev - Re: [PATCH net-next 3/3] net/mlx4_en: Use ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 13:20:25 -0400
From: Kamal Heib <kheib@...hat.com>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Tariq Toukan <tariqt@...dia.com>,
	"David S . Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/3] net/mlx4_en: Use ethtool_puts/sprintf to
 fill stats strings

On Mon, Jun 17, 2024 at 08:06:40AM +0300, Tariq Toukan wrote:
> 
> 
> On 15/06/2024 4:37, Jakub Kicinski wrote:
> > On Thu, 13 Jun 2024 14:43:33 -0400 Kamal Heib wrote:
> > > Use the ethtool_puts/ethtool_sprintf helper to print the stats strings
> > > into the ethtool strings interface.
> > > 
> > > Signed-off-by: Kamal Heib <kheib@...hat.com>
> > 
> > minor build issue with this one:
> > 
> > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:453:6: warning: unused variable 'index' [-Wunused-variable]
> >    453 |         int index = 0;
> >        |             ^~~~~
> > 
> > otherwise LGTM!
> 
> Hi Kamal, thanks for your series.
> Please fix and respin.
>

Hello, 

Sorry about that.
I'll fix it and post v2 shortly.

Thanks,
Kamal