netdev - Re: [PATCH net-next 3/3] net/mlx4_en: Use ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0de75730-5591-42db-911a-abcc24473345@gmail.com>
Date: Mon, 17 Jun 2024 08:06:40 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, Kamal Heib <kheib@...hat.com>
Cc: netdev@...r.kernel.org, Tariq Toukan <tariqt@...dia.com>,
 "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/3] net/mlx4_en: Use ethtool_puts/sprintf to
 fill stats strings

On 15/06/2024 4:37, Jakub Kicinski wrote:
> On Thu, 13 Jun 2024 14:43:33 -0400 Kamal Heib wrote:
>> Use the ethtool_puts/ethtool_sprintf helper to print the stats strings
>> into the ethtool strings interface.
>>
>> Signed-off-by: Kamal Heib <kheib@...hat.com>
> 
> minor build issue with this one:
> 
> drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:453:6: warning: unused variable 'index' [-Wunused-variable]
>    453 |         int index = 0;
>        |             ^~~~~
> 
> otherwise LGTM!

Hi Kamal, thanks for your series.
Please fix and respin.