netdev - Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 07:28:23 +0000
From: Omer Shpigelman <oshpigelman@...ana.ai>
To: Leon Romanovsky <leon@...nel.org>
CC: Przemek Kitszel <przemyslaw.kitszel@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "ogabbay@...nel.org" <ogabbay@...nel.org>,
        Zvika Yehudai <zyehudai@...ana.ai>
Subject: Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

On 6/17/24 14:48, Leon Romanovsky wrote:
> [Some people who received this message don't often get email from leon@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Mon, Jun 17, 2024 at 08:08:26AM +0000, Omer Shpigelman wrote:
>> On 6/13/24 16:01, Przemek Kitszel wrote:
>>> [Some people who received this message don't often get email from przemyslaw.kitszel@...el.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> On 6/13/24 10:21, Omer Shpigelman wrote:
>>>> Add the hbl_cn driver which will serve both Ethernet and InfiniBand
>>>> drivers.
>>>> hbl_cn is the layer which is used by the satellite drivers for many shared
>>>> operations that are needed by both EN and IB subsystems like QPs, CQs etc.
>>>> The CN driver is initialized via auxiliary bus by the habanalabs driver.
>>>>
>>>> Signed-off-by: Omer Shpigelman <oshpigelman@...ana.ai>
>>>> Co-developed-by: Abhilash K V <kvabhilash@...ana.ai>
>>>> Signed-off-by: Abhilash K V <kvabhilash@...ana.ai>
>>>> Co-developed-by: Andrey Agranovich <aagranovich@...ana.ai>
>>>> Signed-off-by: Andrey Agranovich <aagranovich@...ana.ai>
>>>> Co-developed-by: Bharat Jauhari <bjauhari@...ana.ai>
>>>> Signed-off-by: Bharat Jauhari <bjauhari@...ana.ai>
>>>> Co-developed-by: David Meriin <dmeriin@...ana.ai>
>>>> Signed-off-by: David Meriin <dmeriin@...ana.ai>
>>>> Co-developed-by: Sagiv Ozeri <sozeri@...ana.ai>
>>>> Signed-off-by: Sagiv Ozeri <sozeri@...ana.ai>
>>>> Co-developed-by: Zvika Yehudai <zyehudai@...ana.ai>
>>>> Signed-off-by: Zvika Yehudai <zyehudai@...ana.ai>
>>>> ---
>>>>   .../device_drivers/ethernet/index.rst         |    1 +
>>>>   .../device_drivers/ethernet/intel/hbl.rst     |   82 +
>>>>   MAINTAINERS                                   |   11 +
>>>>   drivers/net/ethernet/intel/Kconfig            |   20 +
>>>>   drivers/net/ethernet/intel/Makefile           |    1 +
>>>>   drivers/net/ethernet/intel/hbl_cn/Makefile    |    9 +
>>>>   .../net/ethernet/intel/hbl_cn/common/Makefile |    3 +
>>>>   .../net/ethernet/intel/hbl_cn/common/hbl_cn.c | 5954 +++++++++++++++++
>>>>   .../net/ethernet/intel/hbl_cn/common/hbl_cn.h | 1627 +++++
>>>>   .../ethernet/intel/hbl_cn/common/hbl_cn_drv.c |  220 +
>>>>   .../intel/hbl_cn/common/hbl_cn_memory.c       |   40 +
>>>>   .../ethernet/intel/hbl_cn/common/hbl_cn_phy.c |   33 +
>>>>   .../ethernet/intel/hbl_cn/common/hbl_cn_qp.c  |   13 +
>>>>   include/linux/habanalabs/cpucp_if.h           |  125 +-
>>>>   include/linux/habanalabs/hl_boot_if.h         |    9 +-
>>>>   include/linux/net/intel/cn.h                  |  474 ++
>>>>   include/linux/net/intel/cn_aux.h              |  298 +
>>>>   include/linux/net/intel/cni.h                 |  636 ++
>>>>   18 files changed, 9545 insertions(+), 11 deletions(-)
>>>
>>> this is a very big patch, it asks for a split; what's worse, it's
>>> proportional to the size of this series:
>>>  146 files changed, 148514 insertions(+), 70 deletions(-)
>>> which is just too big
>>>
>>> [...]
>>>
>>
>> Yeah, well I'm limited to 15 patches per patch set according to the kernel
>> doc so I had to have this big patch.
>> Our changes are contained in 4 different drivers and all of the changes
>> should be merged together so the HW will be operational.
>> Hence I had to squeeze some code to a big patch.
> 
> Submit your code in multiple steps. One driver at a time.
> 
> Thanks

I can push each driver at a time but it is missing the big context. Every
single driver is useless without the others (or at least a subset of
them).
But I'll do that anyway so it will be possible to review.
Thanks.