[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240619171535-mutt-send-email-mst@kernel.org>
Date: Wed, 19 Jun 2024 17:16:57 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Heng Qi <hengqi@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, virtualization@...ts.linux.dev,
Jason Wang <jasowang@...hat.com>,
Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
Eugenio PĂ©rez <eperezma@...hat.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v4 0/5] virtio_net: enable the irq for ctrlq
On Thu, Jun 20, 2024 at 12:19:03AM +0800, Heng Qi wrote:
> Ctrlq in polling mode may cause the virtual machine to hang and
> occupy additional CPU resources. Enabling the irq for ctrlq
> alleviates this problem and allows commands to be requested
> concurrently.
Any patch that is supposed to be a performance improvement
has to come with actual before/after testing restults, not
vague "may cause".
> Changelog
> =========
> v3->v4:
> - Turn off the switch before flush the get_cvq work.
> - Add interrupt suppression.
>
> v2->v3:
> - Use the completion for dim cmds.
>
> v1->v2:
> - Refactor the patch 1 and rephase the commit log.
>
> Heng Qi (5):
> virtio_net: passing control_buf explicitly
> virtio_net: enable irq for the control vq
> virtio_net: change the command token to completion
> virtio_net: refactor command sending and response handling
> virtio_net: improve dim command request efficiency
>
> drivers/net/virtio_net.c | 309 ++++++++++++++++++++++++++++++++-------
> 1 file changed, 260 insertions(+), 49 deletions(-)
>
> --
> 2.32.0.3.g01195cf9f
Powered by blists - more mailing lists