netdev - Re: [PATCH net-next 3/3] openvswitch: set IPS_CONFIRMED in tmpl status only when commit is set in conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240619212030.GB1513@breakpoint.cc>
Date: Wed, 19 Jun 2024 23:20:30 +0200
From: Florian Westphal <fw@...len.de>
To: Xin Long <lucien.xin@...il.com>
Cc: Florian Westphal <fw@...len.de>, Ilya Maximets <i.maximets@....org>,
	network dev <netdev@...r.kernel.org>, dev@...nvswitch.org,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	Jiri Pirko <jiri@...nulli.us>, Davide Caratti <dcaratti@...hat.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Cong Wang <xiyou.wangcong@...il.com>, kuba@...nel.org,
	Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Aaron Conole <aconole@...hat.com>
Subject: Re: [PATCH net-next 3/3] openvswitch: set IPS_CONFIRMED in tmpl
 status only when commit is set in conntrack

Xin Long <lucien.xin@...il.com> wrote:
> Got it, I will fix this in ovs.

Thanks!

I don't want to throw more work at you, but since you are
already working on ovs+conntrack:

ovs_ct_init() is bad, as this runs unconditionally.

modprobe openvswitch -> conntrack becomes active in all
existing and future namespaces.

Conntrack is slow, we should avoid this behaviour.

ovs_ct_limit_init() should be called only when the feature is
configured (the problematic call is nf_conncount_init, as that
turns on connection tracking, the kmalloc etc is fine).

Likewise, nf_connlabels_get() should only be called when
labels are added/configured, not at the start.

I resolved this for tc in 70f06c115bcc but it seems i never
got around to fix it for ovs.