netdev - RE: [????] Re: [PATCH] virtio_net: Use u64_stats_fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9f5b5f86b994729a0c408b84fc01ec2@baidu.com>
Date: Fri, 21 Jun 2024 06:20:45 +0000
From: "Li,Rongqing" <lirongqing@...du.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "mst@...hat.com" <mst@...hat.com>, "jasowang@...hat.com"
	<jasowang@...hat.com>, "xuanzhuo@...ux.alibaba.com"
	<xuanzhuo@...ux.alibaba.com>, "eperezma@...hat.com" <eperezma@...hat.com>,
	"hengqi@...ux.alibaba.com" <hengqi@...ux.alibaba.com>,
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [????] Re: [PATCH] virtio_net: Use u64_stats_fetch_begin() for
 stats fetch

> Did you by any chance use an automated tool of any sort to find this issue or
> generate the fix?
> 
> I don't think this is actually necessary here, you're in the same context as the
> updater of the stats, you don't need any protection.
> You can remove u64_stats_update_begin() / end() (in net-next, there's no bug).
> 
> I won't comment on implications of calling dim_update_sample() in a loop.
> 
> Please make sure you answer my "did you use a tool" question, I'm really
> curious.


I have no tool, I find this when I investigating a DIM related issue.

Thanks