netdev - Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1718951303.3419425-15-hengqi@linux.alibaba.com>
Date: Fri, 21 Jun 2024 14:28:23 +0800
From: Heng Qi <hengqi@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 virtualization@...ts.linux.dev,
 "David S . Miller" <davem@...emloft.net>,
 Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>,
 Jason Wang <jasowang@...hat.com>,
 "Michael S . Tsirkin" <mst@...hat.com>,
 Brett Creeley <bcreeley@....com>,
 Ratheesh Kannoth <rkannoth@...vell.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Tal Gilboa <talgi@...dia.com>,
 Jonathan Corbet <corbet@....net>,
 linux-doc@...r.kernel.org,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Jiri Pirko <jiri@...nulli.us>,
 Paul Greenwalt <paul.greenwalt@...el.com>,
 Ahmed Zaki <ahmed.zaki@...el.com>,
 Vladimir Oltean <vladimir.oltean@....com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Andrew Lunn <andrew@...n.ch>,
 justinstitt@...gle.com,
 donald.hunter@...il.com,
 Eugenio Pérez <eperezma@...hat.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Dragos Tatulea <dtatulea@...dia.com>,
 Rahul Rameshbabu <rrameshbabu@...dia.com>,
 Heiner Kallweit <hkallweit1@...il.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 awel Dembicki <paweldembicki@...il.com>
Subject: Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management

On Thu, 20 Jun 2024 20:39:18 -0700, Jakub Kicinski <kuba@...nel.org> wrote:
> On Tue, 18 Jun 2024 10:56:42 +0800 Heng Qi wrote:
> > +	if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_RX) {
> > +		ret = ethnl_update_profile(dev, &dev->irq_moder->rx_profile,
> > +					   tb[ETHTOOL_A_COALESCE_RX_PROFILE],
> > +					   info->extack);
> > +		if (ret < 0)
> > +			return ret;
> > +	}
> > +
> > +	if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_TX) {
> > +		ret = ethnl_update_profile(dev, &dev->irq_moder->tx_profile,
> > +					   tb[ETHTOOL_A_COALESCE_TX_PROFILE],
> > +					   info->extack);
> > +		if (ret < 0)
> > +			return ret;
> > +	}
> 
> One last thing - you're missing updating the &mod bit.
> When any of the settings were change mod should be set
> to true so that we send a notification to user space,
> that the settings have been modified.

Oh, I didn't modify the mod bit in the past because the profile list
modification does not require the dual_change behavior, ignoring the
passing of ret = 0/1. Will modify.

Thanks.