netdev - Re: [PATCH net-next v8 10/13] net: phy: mediatek: Extend 1G TX/RX link pulse time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <931dec9e-e1c3-496c-9242-e5b24595a409@lunn.ch>
Date: Sat, 22 Jun 2024 19:46:07 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Sky Huang <SkyLake.Huang@...iatek.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Daniel Golle <daniel@...rotopia.org>,
	Qingfang Deng <dqfext@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Steven Liu <Steven.Liu@...iatek.com>
Subject: Re: [PATCH net-next v8 10/13] net: phy: mediatek: Extend 1G TX/RX
 link pulse time

On Fri, Jun 21, 2024 at 08:20:42PM +0800, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@...iatek.com>
> 
> We observe that some 10G devices' (mostly Marvell's chips inside) 1G
> training time violates specification, which may last 2230ms and affect
> later TX/RX link pulse time. This will invalidate MediaTek series
> gigabit Ethernet PHYs' hardware auto downshift mechanism.
> 
> Without this patch, if someone is trying to use "4-wire" cable to
> connect above devices, MediaTek' gigabit Ethernet PHYs may fail
> to downshift to 100Mbps. (If partner 10G devices' downshift mechanism
> stops at 1G)
> 
> This patch extends our 1G TX/RX link pulse time so that we can still
> link up with those 10G devices.
> 
> Tested device:
> - Netgear GS110EMX's 10G port (Marvell 88X3340P)
> - QNAP QSW-M408-4C
> 
> Signed-off-by: SkyLake.Huang <skylake.huang@...iatek.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew