netdev - Re: [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document known PHY IDs as compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 01:52:49 +0200
From: Marek Vasut <marex@...x.de>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>,
 Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>,
 Joakim Zhang <qiangqing.zhang@....com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
 kernel@...electronics.com
Subject: Re: [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document
 known PHY IDs as compatible strings

On 6/23/24 10:00 PM, Andrew Lunn wrote:
>>     - $ref: ethernet-phy.yaml#
>>   
>>   properties:
>> +  compatible:
>> +    enum:
>> +      - ethernet-phy-id0000.8201
> 
> I'm not sure that one should be listed. It is not an official ID,
> since it does not have an OUI. In fact, this is one of the rare cases
> where actually listing a compatible in DT makes sense, because you can
> override the broken hardware and give a correct ID in realtek address
> space.

Hmmm, so, shall I drop this ID or keep it ?

I generally put the PHY IDs into DT so the PHY drivers can correctly 
handle clock and reset sequencing for those PHYs, before the PHY ID 
registers can be read out of the PHY.