[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <xafdw4u5nqknn2qehkke5p4mrj4bnfh33pcmkob5gbl7y5apr4@pkwmf6vphxsh>
Date: Mon, 24 Jun 2024 04:47:28 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Yanteng Si <siyanteng@...ngson.cn>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
netdev@...r.kernel.org, chris.chenfeiyang@...il.com, si.yanteng@...ux.dev
Subject: Re: [PATCH net-next v13 06/15] net: stmmac: dwmac-loongson: Detach
GMAC-specific platform data init
On Mon, Jun 17, 2024 at 06:00:19PM +0800, Yanteng Si wrote:
> Hi Serge,
>
> 在 2024/6/15 00:19, Serge Semin 写道:
> > On Wed, May 29, 2024 at 06:19:03PM +0800, Yanteng Si wrote:
> > > Loongson delivers two types of the network devices: Loongson GMAC and
> > > Loongson GNET in the framework of four CPU/Chipsets revisions:
> > >
> > > Chip Network PCI Dev ID Synopys Version DMA-channel
> > > LS2K1000 CPU GMAC 0x7a03 v3.50a/v3.73a 1
> > > LS7A1000 Chipset GMAC 0x7a03 v3.50a/v3.73a 1
> > > LS2K2000 CPU GNET 0x7a13 v3.73a 8
> > > LS7A2000 Chipset GNET 0x7a13 v3.73a 1
> > You mentioned in the cover-letter
> > https://lore.kernel.org/netdev/cover.1716973237.git.siyanteng@loongson.cn/
> > that LS2K now have GMAC NICs too:
> > " 1. The current LS2K2000 also have a GMAC(and two GNET) that supports 8
> > channels, so we have to reconsider the initialization of
> > tx/rx_queues_to_use into probe();"
> >
> > But I don't see much changes in the series which would indicate that
> > new data. Please clarify what does it mean:
> >
> > Does it mean LS2K2000 has two types of the DW GMACs, right?
> Yes!
> >
> > Are both of them based on the DW GMAC v3.73a IP-core with AV-feature
> > enabled and 8 DMA-channels?
> Yes!
> >
> > Seeing you called the new device as GMAC it doesn't have an
> > integrated PHY as GNETs do, does it? If so, then neither
> > STMMAC_FLAG_DISABLE_FORCE_1000 nor loongson_gnet_fix_speed() relevant
> > for the new device, right?
> YES!
> >
> > Why haven't you changed the sheet in the commit log? Shall the sheet
> > be updated like this:
> >
> > Chip Network PCI Dev ID Synopys Version DMA-channel
> > LS2K1000 CPU GMAC 0x7a03 v3.50a/v3.73a 1
> > LS7A1000 Chipset GMAC 0x7a03 v3.50a/v3.73a 1
> > +LS2K2000 CPU GMAC 0x7a13 v3.73a 8
> > LS2K2000 CPU GNET 0x7a13 v3.73a 8
> > LS7A2000 Chipset GNET 0x7a13 v3.73a 1
> >
> > ?
>
> No! PCI Dev ID of GMAC is 0x7a03. So:
>
> LS2K1000 CPU GMAC 0x7a03 v3.50a/v3.73a 1
> LS7A1000 Chipset GMAC 0x7a03 v3.50a/v3.73a 1
> +LS2K2000 CPU GMAC 0x7a03 v3.73a 8
> LS2K2000 CPU GNET 0x7a13 v3.73a 8
> LS7A2000 Chipset GNET 0x7a13 v3.73a 1
>
> >
> > I'll continue reviewing the series after the questions above are
> > clarified.
>
> OK, If anything else is unclear, please let me know.
Got it. Thanks for clarifying. I'll get back to reviewing the series
tomorrow. Sorry for the timebreak.
-Serge(y)
Powered by blists - more mailing lists