netdev - Re: [PATCH net-next v8 07/13] net: phy: mediatek: add MT7530 & MT7531's PHY ID macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22eb091dd34bbd9b3a159eee9d8b2557c83c434f.camel@mediatek.com>
Date: Mon, 24 Jun 2024 10:39:28 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"dqfext@...il.com" <dqfext@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH net-next v8 07/13] net: phy: mediatek: add MT7530 &
 MT7531's PHY ID macros

On Sat, 2024-06-22 at 19:32 +0200, Andrew Lunn wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Fri, Jun 21, 2024 at 08:20:39PM +0800, Sky Huang wrote:
> > From: "SkyLake.Huang" <skylake.huang@...iatek.com>
> > 
> > This patch adds MT7530 & MT7531's PHY ID macros in mtk-ge.c so that
> > it follows the same rule of mtk-ge-soc.c.
> > @@ -170,9 +173,10 @@ static struct phy_driver mtk_gephy_driver[] =
> {
> >  .resume= genphy_resume,
> >  .read_page= mtk_phy_read_page,
> >  .write_page= mtk_phy_write_page,
> > +.led_hw_is_supported = mt753x_phy_led_hw_is_supported,
> 
> Was this intentional. It does not fit the commit message, so i
> wounder
> if it should be somewhere else?
> 
> Otherwise:
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
>     Andrew

I think I mistakely added this into MT7530's callback functions
declarations. I'll remove this in next version.

BRs,
Sky