netdev - Re: [PATCH net-next v8 09/13] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4740076aee9b42aab766bcc041fe67a28753d12.camel@mediatek.com>
Date: Mon, 24 Jun 2024 10:41:12 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"dqfext@...il.com" <dqfext@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH net-next v8 09/13] net: phy: mediatek: Add token ring
 access helper functions in mtk-phy-lib

On Sat, 2024-06-22 at 19:41 +0200, Andrew Lunn wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Fri, Jun 21, 2024 at 08:20:41PM +0800, Sky Huang wrote:
> > From: "SkyLake.Huang" <skylake.huang@...iatek.com>
> > 
> > This patch adda TR(token ring) manipulations and add correct
> 
> s/adda/adds
> 
> plus "adds the correct macro names for"
> 
> > macro name for those magic numbers. TR is a way to access
> > proprietary register on page 52b5. Use these helper functions
> 
> registers
> 
> > +/* ch_addr = 0x2, node_addr = 0xd, data_addr = 0x8 */
> > +/* clear this bit if wanna select from AFE */
> > +/* Regsigdet_sel_1000 */
> > +#define EEE1000_SELECT_SIGNEL_DETECTION_FROM_DFEBIT(4)
> 
> Should that be SIGNAL?
> 
> Andrew

Yes, SIGNAL is correct. I'll fix all of the above in next version.

BRs,
Sky