netdev - Re: [PATCH net-next v8 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <461abaf6b5386071fed9d5b1eba629d794c1810c.camel@mediatek.com>
Date: Mon, 24 Jun 2024 10:46:24 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"dqfext@...il.com" <dqfext@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH net-next v8 11/13] net: phy: add driver for built-in 2.5G
 ethernet PHY on MT7988

> > +
> > +#define MTK_2P5GPHY_ID_MT7988(0x00339c11)
> > +
> > +#define MT7988_2P5GE_PMB "mediatek/mt7988/i2p5ge-phy-pmb.bin"
> 
> You probably want a MODULE_FIRMWARE() so the firmware gets placed
> into
> the initrd.
> 
Agree. I'll add MODULE_FIRMWARE() in next version.

> > +#define BASE100T_STATUS_EXTEND(0x10)
> > +#define BASE1000T_STATUS_EXTEND(0x11)
> > +#define EXTEND_CTRL_AND_STATUS(0x16)
> 
> These don't appear to be used.
> 
>       Andrew

Sorry for this left-over. I'll remove these three unused macro names
and PHY_AUX_DPX_MASK.

BRs,
Sky