netdev - Re: [PATCH 10/15] net: hinic: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 12:47:59 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Allen Pais <allen.lkml@...il.com>, kuba@...nel.org, Cai Huoqing
 <cai.huoqing@...ux.dev>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>
Cc: jes@...ined-monkey.org, kda@...ux-powerpc.org, dougmill@...ux.ibm.com, 
 npiggin@...il.com, christophe.leroy@...roup.eu, aneesh.kumar@...nel.org, 
 naveen.n.rao@...ux.ibm.com, nnac123@...ux.ibm.com, tlfalcon@...ux.ibm.com, 
 cooldavid@...ldavid.org, marcin.s.wojtas@...il.com, mlindner@...vell.com, 
 stephen@...workplumber.org, nbd@....name, sean.wang@...iatek.com, 
 Mark-MC.Lee@...iatek.com, lorenzo@...nel.org, matthias.bgg@...il.com, 
 angelogioacchino.delregno@...labora.com, borisp@...dia.com, 
 bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com, 
 louis.peens@...igine.com, richardcochran@...il.com,
 linux-rdma@...r.kernel.org,  linux-kernel@...r.kernel.org,
 linux-acenic@...site.dk, linux-net-drivers@....com,  netdev@...r.kernel.org
Subject: Re: [PATCH 10/15] net: hinic: Convert tasklet API to new bottom
 half workqueue mechanism

On Thu, 2024-06-20 at 22:05 -0700, Allen Pais wrote:
> @@ -968,9 +968,8 @@ void hinic_dump_ceq_info(struct hinic_hwdev *hwdev)
>  		ci = hinic_hwif_read_reg(hwdev->hwif, addr);
>  		addr = EQ_PROD_IDX_REG_ADDR(eq);
>  		pi = hinic_hwif_read_reg(hwdev->hwif, addr);
> -		dev_err(&hwdev->hwif->pdev->dev, "Ceq id: %d, ci: 0x%08x, sw_ci: 0x%08x, pi: 0x%x, tasklet_state: 0x%lx, wrap: %d, ceqe: 0x%x\n",
> +		dev_err(&hwdev->hwif->pdev->dev, "Ceq id: %d, ci: 0x%08x, sw_ci: 0x%08x, pi: 0x%x, wrap: %d, ceqe: 0x%x\n",
>  			q_id, ci, eq->cons_idx, pi,
> -			eq->ceq_tasklet.state,

I guess here you can show work_pending() as a partial replacement for
the tasklet state.

Thanks!

Paolo