netdev - Re: [PATCH net] net: txgbe: fix MSI and INTx interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d975b97d9eda6c85fa5133aaed32b985cb6296b.camel@redhat.com>
Date: Tue, 25 Jun 2024 13:00:06 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, horms@...nel.org, andrew@...n.ch, 
	netdev@...r.kernel.org
Cc: mengyuanlou@...-swift.com, duanqiangwen@...-swift.com
Subject: Re: [PATCH net] net: txgbe: fix MSI and INTx interrupts

On Fri, 2024-06-21 at 16:09 +0800, Jiawen Wu wrote:
> When using MSI or INTx interrupts, request_irq() for pdev->irq will
> conflict with request_threaded_irq() for txgbe->misc.irq, to cause
> system crash.
> 
> Fixes: aefd013624a1 ("net: txgbe: use irq_domain for interrupt controller")
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>

I think you should add a longish description here.
This fix is fairly non trivial but the above contains no hint on how
and why the fix is supposed to address the issue.

Thanks,

Paolo