netdev - Re: [PATCH net-next v4 04/10] net: psample: allow using rate as probability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f6aa18e38ff3c161805b19780c6265d05b4a235.camel@redhat.com>
Date: Tue, 25 Jun 2024 13:17:19 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Adrian Moreno <amorenoz@...hat.com>, netdev@...r.kernel.org
Cc: aconole@...hat.com, echaudro@...hat.com, horms@...nel.org,
 i.maximets@....org,  dev@...nvswitch.org, Yotam Gigi <yotam.gi@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Jamal Hadi Salim
 <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko
 <jiri@...nulli.us>,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 04/10] net: psample: allow using rate as
 probability

On Fri, 2024-06-21 at 12:10 +0200, Adrian Moreno wrote:
> diff --git a/include/uapi/linux/tc_act/tc_sample.h b/include/uapi/linux/tc_act/tc_sample.h
> index fee1bcc20793..7ee0735e7b38 100644
> --- a/include/uapi/linux/tc_act/tc_sample.h
> +++ b/include/uapi/linux/tc_act/tc_sample.h
> @@ -18,6 +18,7 @@ enum {
>  	TCA_SAMPLE_TRUNC_SIZE,
>  	TCA_SAMPLE_PSAMPLE_GROUP,
>  	TCA_SAMPLE_PAD,
> +	TCA_SAMPLE_PROBABILITY,
>  	__TCA_SAMPLE_MAX
>  };
>  #define TCA_SAMPLE_MAX (__TCA_SAMPLE_MAX - 1)

I believe Ilya's comment on v3 is correct, this chunk looks unrelated
and unneeded. I guess you can drop it? Or am I missing something?

Thanks,

Paolo