netdev - Re: [PATCH net-next] net: Drop explicit initialization of struct i2c_device_id::driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f93aadeee5963955df61be2a245d0857a2ba93c0.camel@codeconstruct.com.au>
Date: Wed, 26 Jun 2024 07:56:44 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, 
 Vladimir Oltean <olteanv@...il.com>, Woojung Huh
 <woojung.huh@...rochip.com>, UNGLinuxDriver@...rochip.com,  George
 McCollister <george.mccollister@...il.com>, Ido Schimmel
 <idosch@...dia.com>, Petr Machata <petrm@...dia.com>,  Matt Johnston
 <matt@...econstruct.com.au>, Oleksij Rempel <o.rempel@...gutronix.de>, Kory
 Maincent <kory.maincent@...tlin.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: Drop explicit initialization of struct
 i2c_device_id::driver_data to 0

Hi Uwe,

> These drivers don't use the driver_data member of struct
> i2c_device_id, so don't explicitly initialize this member.
> 
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named designators. But it's also a nice
> cleanup on its own.
> 
> While add it, also remove commas after the sentinel entries.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

Thanks!

Reviewed-by: Jeremy Kerr <jk@...econstruct.com.au> # for mctp-i2c

Cheers,

Jeremy