netdev - Re: [PATCH net-next] net: Drop explicit initialization of struct i2c_device_id::driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 07:00:08 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	UNGLinuxDriver@...rochip.com,
	George McCollister <george.mccollister@...il.com>,
	Ido Schimmel <idosch@...dia.com>, Petr Machata <petrm@...dia.com>,
	Jeremy Kerr <jk@...econstruct.com.au>,
	Matt Johnston <matt@...econstruct.com.au>,
	Kory Maincent <kory.maincent@...tlin.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: Drop explicit initialization of struct
 i2c_device_id::driver_data to 0

Hi Uwe,

On Tue, Jun 25, 2024 at 10:38:53AM +0200, Uwe Kleine-König wrote:
> These drivers don't use the driver_data member of struct i2c_device_id,
> so don't explicitly initialize this member.
> 
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named designators. But it's also a nice
> cleanup on its own.
> 
> While add it, also remove commas after the sentinel entries.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
> Hello,
> 
> I'm unsure if I should have split this patch further; per subdir of
> drivers/net or even per driver. If you want it split, please tell me. 
> 
> Best regards
> Uwe
> 
>  drivers/net/dsa/lan9303_i2c.c                 | 2 +-
>  drivers/net/dsa/microchip/ksz9477_i2c.c       | 4 ++--

Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

>  drivers/net/pse-pd/pd692x0.c                  | 4 ++--
>  drivers/net/pse-pd/tps23881.c                 | 4 ++--

Acked-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you!

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |