[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <90e2bda8-5f5d-409f-8b4a-b2cd12747c95@intel.com>
Date: Tue, 25 Jun 2024 09:17:47 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Edward Cree <ecree.xilinx@...il.com>, <edward.cree@....com>
CC: <linux-net-drivers@....com>, <netdev@...r.kernel.org>,
<habetsm.xilinx@...il.com>, <sudheer.mogilappagari@...el.com>,
<jdamato@...tly.com>, <mw@...ihalf.com>, <linux@...linux.org.uk>,
<sgoutham@...vell.com>, <gakula@...vell.com>, <sbhatta@...vell.com>,
<hkelam@...vell.com>, <saeedm@...dia.com>, <leon@...nel.org>,
<jacob.e.keller@...el.com>, <andrew@...n.ch>, <ahmed.zaki@...el.com>,
<davem@...emloft.net>, <kuba@...nel.org>, <edumazet@...gle.com>,
<pabeni@...hat.com>
Subject: Re: [PATCH v6 net-next 3/9] net: ethtool: record custom RSS contexts
in the XArray
On 6/20/24 08:37, Edward Cree wrote:
> On 20/06/2024 07:32, Przemek Kitszel wrote:
>> On 6/20/24 07:47, edward.cree@....com wrote:
>>> From: Edward Cree <ecree.xilinx@...il.com>
>>>
>>> Since drivers are still choosing the context IDs, we have to force the
>>> XArray to use the ID they've chosen rather than picking one ourselves,
>>> and handle the case where they give us an ID that's already in use.
>>
>> Q: This is a new API, perhaps you could force adopters to convert to
>> not choosing ID and switching to allocated one?
>
> Yes, that's exactly what the next patch (#4) does, when it introduces
> the new API.
Thanks, I noticed it only after reading this patch.
I know that there are is v7 already, but I don't know if you just missed
my other comments to this v6 patch, or they are not relevant after you
answering the first question? (Code is not removed in subsequent patch,
so I guess you just missed).
Powered by blists - more mailing lists