netdev - Re: [PATCH v2] s390/netiucv: handle memory allocation failure in conn_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 09:24:18 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Yunseong Kim <yskelg@...il.com>, linux-s390@...r.kernel.org,
 netdev@...r.kernel.org, Alexander Gordeev <agordeev@...ux.ibm.com>,
 Alexandra Winter <wintera@...ux.ibm.com>,
 Christian Bornträger <borntraeger@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>,
 Thorsten Winkler <twinkler@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>
Cc: LKML <linux-kernel@...r.kernel.org>, MichelleJin <shjy180909@...il.com>
Subject: Re: [PATCH v2] s390/netiucv: handle memory allocation failure in
 conn_action_start()

> … Thus add a corresponding return value

I suggest to move this sentence into a subsequent text line.

>      … This prevent null pointer dereferenced kernel panic when memory
> exhausted situation with the netiucv driver operating as an FSM state
> in "conn_action_start".

Do you find an improved wording still relevant for a separate paragraph?

> Fixes: eebce3856737 ("[S390]: Adapt netiucv driver to new IUCV API")
> Cc: linux-s390@...r.kernel.org

Would you like to specify a “stable tag”?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.10-rc5#n34

> ---

I would appreciate a version description behind the marker line.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n713

…
> +++ b/drivers/s390/net/netiucv.c
> @@ -855,6 +855,9 @@ static void conn_action_start(fsm_instance *fi, int event, void *arg)
>
>  	fsm_newstate(fi, CONN_STATE_SETUPWAIT);
>  	conn->path = iucv_path_alloc(NETIUCV_QUEUELEN_DEFAULT, 0, GFP_KERNEL);
> +	if (!conn->path)
> +		return;
…

Would the following statement variant become more appropriate here?

+		return -ENOMEM;

Regards,
Markus