netdev - Re: [PATCH net-next v5 03/10] net: psample: skip packet copy if no listeners

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnvA1l3dhtj9MP6X@shredder.mtl.com>
Date: Wed, 26 Jun 2024 10:18:46 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Adrian Moreno <amorenoz@...hat.com>
Cc: netdev@...r.kernel.org, aconole@...hat.com, echaudro@...hat.com,
	horms@...nel.org, i.maximets@....org, dev@...nvswitch.org,
	Yotam Gigi <yotam.gi@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 03/10] net: psample: skip packet copy if no
 listeners

On Tue, Jun 25, 2024 at 10:51:46PM +0200, Adrian Moreno wrote:
> If nobody is listening on the multicast group, generating the sample,
> which involves copying packet data, seems completely unnecessary.
> 
> Return fast in this case.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Adrian Moreno <amorenoz@...hat.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>