netdev - Re: [PATCH] net: ntb_netdev: Move ntb_netdev_rx_handler() to call netif_rx() from __netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240627165436.19e82af5@kernel.org>
Date: Thu, 27 Jun 2024 16:54:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dave Jiang <dave.jiang@...el.com>
Cc: ntb@...ts.linux.dev, netdev@...r.kernel.org, jdmason@...zu.us,
 allenbh@...il.com, davem@...emloft.net, edumazet@...gle.com,
 abeni@...hat.com, Jerry Dai <jerry.dai@...el.com>
Subject: Re: [PATCH] net: ntb_netdev: Move ntb_netdev_rx_handler() to call
 netif_rx() from __netif_rx()

On Wed, 26 Jun 2024 11:06:13 -0700 Dave Jiang wrote:
> Fixes: baebdf48c360 ("net: dev: Makes sure netif_rx() can be invoked in any context.")

Patch LGTM, but I think the Fixes tag needs to go back further.
Sebastian renamed and flipped semantics at the same time, so
what he did for this driver should be a noop.
IOW prior to his change netif_rx() expected to be called with
BH disabled, and the driver should have been using netif_rx_ni()
or netif_rx_any_context().
Maybe add this extra info to the commit message, there's also a way
to point out a dependency via a special tag..
But the Fixes tag should point to where the bug was introduced.
-- 
pw-bot: cr