netdev - Re: [PATCH net-next v13 12/15] net: stmmac: Fixed failure to set network speed to 1000.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gndedhwq6q6ou56nxnld6irkv4curb7mql4sy2i4wx5qnqksoh@6kpyuozs656l>
Date: Tue, 2 Jul 2024 13:31:44 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: si.yanteng@...ux.dev, "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Huacai Chen <chenhuacai@...nel.org>, 
	Yanteng Si <siyanteng@...ngson.cn>, andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com, 
	alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com, 
	guyinggang@...ngson.cn, netdev@...r.kernel.org, chris.chenfeiyang@...il.com
Subject: Re: [PATCH net-next v13 12/15] net: stmmac: Fixed failure to set
 network speed to 1000.

On Tue, Jun 04, 2024 at 11:29:43AM +0000, si.yanteng@...ux.dev wrote:
> 2024年5月30日 15:22, "Russell King (Oracle)" <linux@...linux.org.uk> 写到:
> 
> Hi, Russell, Serge,
> 
> > 
> > On Thu, May 30, 2024 at 10:25:01AM +0800, Huacai Chen wrote:
> > 
> > > 
> > > Hi, Yanteng,
> > > 
> > >  
> > > 
> > >  The title should be "Fix ....." rather than "Fixed .....", and it is
> > > 
> > 
> > I would avoid the ambiguous "Fix" which for stable folk imply that this
> > 
> > is a bug fix - but it isn't. It's adding support for requiring 1G
> > 
> > speeds to always be negotiated.
> Oh, I get it now. Thanks!
> 
> > 
> > I would like this patch to be held off until more thought can be put
> > 
> > into how to handle this without having a hack in the driver (stmmac
> > 
> > has too many hacks and we're going to have to start saying no to
> > 
> > these.)
> Yeah, you have a point there, but I would also like to hear Serge's opinion.

I would be really glad not to have so many hacks in the STMMAC driver.
It would have been awesome if we are able to find a solution without
introducing one more quirk in the common driver code.

I started digging into this sometime ago, but failed to come up with
any decent hypothesis about the problem nature. One of the glimpse
idea was that the loongson_gnet_fix_speed() method code might be somehow
connected with the problem. But I didn't have much time to go further
than that.

Anyway I guess we'll need to have at least two more patchset
re-spins to settle all the found issues. Until then we can keep
discussing the problem Yanteng experience on his device. Russell, do
you have any suggestion of what info Yanteng should provide to better
understand the problem and get closer to it' cause?

-Serge(y)

> 
> 
> 
> Thanks,
> Yanteng