netdev - Re: [PATCH v4 2/2] net: airoha: Introduce ethernet support for EN7581 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoO8iYz1lj8PoLcB@lore-rh-laptop>
Date: Tue, 2 Jul 2024 10:38:33 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, nbd@....name, lorenzo.bianconi83@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, conor@...nel.org,
	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	devicetree@...r.kernel.org, catalin.marinas@....com,
	will@...nel.org, upstream@...oha.com,
	angelogioacchino.delregno@...labora.com,
	benjamin.larsson@...exis.eu, rkannoth@...vell.com,
	sgoutham@...vell.com, andrew@...n.ch, arnd@...db.de
Subject: Re: [PATCH v4 2/2] net: airoha: Introduce ethernet support for
 EN7581 SoC

> On Sat, Jun 29, 2024 at 05:01:38PM +0200, Lorenzo Bianconi wrote:
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c
> 
> ...
> 
> > +#define INT_IDX4_MASK						\
> > +	(TX8_COHERENT_INT_MASK | TX9_COHERENT_INT_MASK |	\
> > +	 TX10_COHERENT_INT_MASK | TX11_COHERENT_INT_MASK |	\
> > +	 TX12_COHERENT_INT_MASK | TX13_COHERENT_INT_MASK |	\
> > +	 TX14_COHERENT_INT_MASK | TX15_COHERENT_INT_MASK |	\
> > +	 TX16_COHERENT_INT_MASK | TX17_COHERENT_INT_MASK |	\
> > +	 TX18_COHERENT_INT_MASK | TX19_COHERENT_INT_MASK |	\
> > +	 TX20_COHERENT_INT_MASK | TX21_COHERENT_INT_MASK |	\
> > +	 TX20_COHERENT_INT_MASK | TX21_COHERENT_INT_MASK |	\
> 
> Hi Lorenzo,
> 
> One more thing that I forgot to note yesterday:
> the two lines above appear to be duplicates of each other.

ack, thx. I will fix it in v5.

Regards,
Lorenzo

> 
> Flagged by Coccinelle.
> 
> > +	 TX22_COHERENT_INT_MASK | TX23_COHERENT_INT_MASK |	\
> > +	 TX24_COHERENT_INT_MASK | TX25_COHERENT_INT_MASK |	\
> > +	 TX26_COHERENT_INT_MASK | TX27_COHERENT_INT_MASK |	\
> > +	 TX28_COHERENT_INT_MASK | TX29_COHERENT_INT_MASK |	\
> > +	 TX30_COHERENT_INT_MASK | TX31_COHERENT_INT_MASK)
> 
> ...

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)