netdev - Re: [PATCH net-next] ethtool: move firmware flashing flag to struct ethtool_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoVgeHbWG7N5yj9s@localhost.localdomain>
Date: Wed, 3 Jul 2024 16:30:16 +0200
From: Michal Kubiak <michal.kubiak@...el.com>
To: <edward.cree@....com>
CC: <davem@...emloft.net>, <kuba@...nel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, Edward Cree <ecree.xilinx@...il.com>,
	<netdev@...r.kernel.org>, <danieller@...dia.com>, <andrew@...n.ch>
Subject: Re: [PATCH net-next] ethtool: move firmware flashing flag to struct
 ethtool_netdev_state

On Wed, Jul 03, 2024 at 01:18:49PM +0100, edward.cree@....com wrote:
> From: Edward Cree <ecree.xilinx@...il.com>
> 
> Commit 31e0aa99dc02 ("ethtool: Veto some operations during firmware flashing process")
>  added a flag module_fw_flash_in_progress to struct net_device.  As

Nitpick: unnecessary space

>  this is ethtool related state, move it to the recently created
>  struct ethtool_netdev_state, accessed via the 'ethtool' member of
>  struct net_device.

Nitpick: wrong indentation in the commit message

> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Edward Cree <ecree.xilinx@...il.com>
> ---
> Build tested only.

The code changes look OK. Just the commit message formatting needs to be
polished a little bit.

Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>