netdev - Re: ethtool fails to read some QSFP+ modules.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49bf6eca-9ad0-49a7-ac8d-d5104581f137@ans.pl>
Date: Wed, 3 Jul 2024 07:36:52 -0700
From: Krzysztof Olędzki <ole@....pl>
To: Ido Schimmel <idosch@...sch.org>, Dan Merillat <git@....merillat.org>
Cc: Michal Kubecek <mkubecek@...e.cz>, netdev <netdev@...r.kernel.org>
Subject: Re: ethtool fails to read some QSFP+ modules.

Good morning,

On 01.07.2024 at 00:41, Ido Schimmel wrote:
> Forgot to add Krzysztof :p
> 
> On Mon, Jul 01, 2024 at 10:28:39AM +0300, Ido Schimmel wrote:
>> On Sun, Jun 30, 2024 at 01:27:07PM -0400, Dan Merillat wrote:
>>>
>>> I was testing an older Kaiam XQX2502 40G-LR4 and ethtool -m failed with netlink error.  It's treating a failure to read
>>> the optional page3 data as a hard failure.
>>>
>>> This patch allows ethtool to read qsfp modules that don't implement the voltage/temperature alarm data.
>>
>> Thanks for the report and the patch. Krzysztof Olędzki reported the same
>> issue earlier this year:
>> https://lore.kernel.org/netdev/9e757616-0396-4573-9ea9-3cb5ef5c901a@ans.pl/
>>
>> Krzysztof, are you going to submit the ethtool and mlx4 patches?

Yes, and I apologize for the delay - I have been traveling with my family and was unable to get into it.

I should be able to work on the patches later this week, so please expect something from me around the weekend.

>>> From 3144fbfc08fbfb90ecda4848fc9356bde8933d4a Mon Sep 17 00:00:00 2001
>>> From: Dan Merillat <git@....eginity.com>
>>> Date: Sun, 30 Jun 2024 13:11:51 -0400
>>> Subject: [PATCH] Some qsfp modules do not support page 3
>>>
>>> Tested on an older Kaiam XQX2502 40G-LR4 module.
>>> ethtool -m aborts with netlink error due to page 3
>>> not existing on the module. Ignore the error and
>>> leave map->page_03h NULL.
>>
>> User space only tries to read this page because the module advertised it
>> as supported. It is more likely that the NIC driver does not return all
>> the pages. Which driver is it?
> 

Thanks,
 Krzysztof