netdev - Re: [PATCH 29/47] dt-bindings: net: qcom,ethqos: add description for qcs9100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <u5ekupjqvgoehkl76pv7ljyqqzbnnyh6ci2dilfxfkcdvdy3dp@ehdujhkul7ow>
Date: Wed, 3 Jul 2024 10:09:36 -0500
From: Andrew Halaney <ahalaney@...hat.com>
To: Tengfei Fan <quic_tengfan@...cinc.com>
Cc: andersson@...nel.org, konrad.dybcio@...aro.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, djakov@...nel.org, mturquette@...libre.com, 
	sboyd@...nel.org, jassisinghbrar@...il.com, herbert@...dor.apana.org.au, 
	davem@...emloft.net, manivannan.sadhasivam@...aro.org, will@...nel.org, 
	joro@...tes.org, conor@...nel.org, tglx@...utronix.de, amitk@...nel.org, 
	thara.gopinath@...il.com, linus.walleij@...aro.org, wim@...ux-watchdog.org, 
	linux@...ck-us.net, rafael@...nel.org, viresh.kumar@...aro.org, vkoul@...nel.org, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, mcoquelin.stm32@...il.com, 
	robimarko@...il.com, quic_gurus@...cinc.com, bartosz.golaszewski@...aro.org, 
	kishon@...nel.org, quic_wcheng@...cinc.com, alim.akhtar@...sung.com, 
	avri.altman@....com, bvanassche@....org, agross@...nel.org, 
	gregkh@...uxfoundation.org, quic_tdas@...cinc.com, robin.murphy@....com, 
	daniel.lezcano@...aro.org, rui.zhang@...el.com, lukasz.luba@....com, 
	quic_rjendra@...cinc.com, ulf.hansson@...aro.org, quic_sibis@...cinc.com, 
	otto.pflueger@...cue.de, quic_rohiagar@...cinc.com, luca@...tu.xyz, 
	neil.armstrong@...aro.org, abel.vesa@...aro.org, bhupesh.sharma@...aro.org, 
	alexandre.torgue@...s.st.com, peppe.cavallaro@...com, joabreu@...opsys.com, 
	netdev@...r.kernel.org, lpieralisi@...nel.org, kw@...ux.com, bhelgaas@...gle.com, 
	krzysztof.kozlowski@...aro.org, u.kleine-koenig@...gutronix.de, dmitry.baryshkov@...aro.org, 
	quic_cang@...cinc.com, danila@...xyga.com, quic_nitirawa@...cinc.com, 
	mantas@...vices.com, athierry@...hat.com, quic_kbajaj@...cinc.com, 
	quic_bjorande@...cinc.com, quic_msarkar@...cinc.com, quic_devipriy@...cinc.com, 
	quic_tsoni@...cinc.com, quic_rgottimu@...cinc.com, quic_shashim@...cinc.com, 
	quic_kaushalk@...cinc.com, quic_tingweiz@...cinc.com, quic_aiquny@...cinc.com, 
	srinivas.kandagatla@...aro.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-phy@...ts.infradead.org, linux-crypto@...r.kernel.org, linux-scsi@...r.kernel.org, 
	linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev, 
	linux-riscv@...ts.infradead.org, linux-gpio@...r.kernel.org, linux-watchdog@...r.kernel.org, 
	linux-pci@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, kernel@...cinc.com
Subject: Re: [PATCH 29/47] dt-bindings: net: qcom,ethqos: add description for
 qcs9100

On Wed, Jul 03, 2024 at 10:58:32AM GMT, Tengfei Fan wrote:
> Add the compatible for the MAC controller on qcs9100 platforms. This MAC
> works with a single interrupt so add minItems to the interrupts property.
> The fourth clock's name is different here so change it. Enable relevant
> PHY properties. Add the relevant compatibles to the binding document for
> snps,dwmac as well.

This description doesn't match what was done in this patch, its what
Bart did when he made changes to add the sa8775 changes. Please consider
using a blurb indicating that this is the same SoC as sa8775p, just with
different firmware strategies or something along those lines?

> 
> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
> ---
>  Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 1 +
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml  | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 6672327358bc..8ab11e00668c 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -20,6 +20,7 @@ properties:
>    compatible:
>      enum:
>        - qcom,qcs404-ethqos
> +      - qcom,qcs9100-ethqos
>        - qcom,sa8775p-ethqos
>        - qcom,sc8280xp-ethqos
>        - qcom,sm8150-ethqos
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 3bab4e1f3fbf..269c21779396 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -67,6 +67,7 @@ properties:
>          - loongson,ls2k-dwmac
>          - loongson,ls7a-dwmac
>          - qcom,qcs404-ethqos
> +        - qcom,qcs9100-ethqos
>          - qcom,sa8775p-ethqos
>          - qcom,sc8280xp-ethqos
>          - qcom,sm8150-ethqos
> @@ -582,6 +583,7 @@ allOf:
>                - ingenic,x1600-mac
>                - ingenic,x1830-mac
>                - ingenic,x2000-mac
> +              - qcom,qcs9100-ethqos
>                - qcom,sa8775p-ethqos
>                - qcom,sc8280xp-ethqos
>                - snps,dwmac-3.50a
> @@ -639,6 +641,7 @@ allOf:
>                - ingenic,x1830-mac
>                - ingenic,x2000-mac
>                - qcom,qcs404-ethqos
> +              - qcom,qcs9100-ethqos
>                - qcom,sa8775p-ethqos
>                - qcom,sc8280xp-ethqos
>                - qcom,sm8150-ethqos
> -- 
> 2.25.1
>