netdev - Re: [PATCH net] net: stmmac: dwmac4: fix PCS duplex mode decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4sseitixno7uegbpufcqbutgqjywkmqi7tc3xoy5g6kr75be2w@zm3symrbpzcm>
Date: Wed, 3 Jul 2024 20:26:11 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Andrew Halaney <ahalaney@...hat.com>, 
	Heiner Kallweit <hkallweit1@...il.com>, "Abhishek Chauhan (ABC)" <quic_abchauha@...cinc.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net] net: stmmac: dwmac4: fix PCS duplex mode decode

On Wed, Jul 03, 2024 at 04:29:24PM +0100, Russell King (Oracle) wrote:
> On Wed, Jul 03, 2024 at 06:07:54PM +0300, Serge Semin wrote:
> > On Wed, Jul 03, 2024 at 04:06:54PM +0200, Andrew Lunn wrote:
> > > On Wed, Jul 03, 2024 at 01:24:40PM +0100, Russell King (Oracle) wrote:
> > > > dwmac4 was decoding the duplex mode from the GMAC_PHYIF_CONTROL_STATUS
> > > > register incorrectly, using GMAC_PHYIF_CTRLSTATUS_LNKMOD_MASK (value 1)
> > > > rather than GMAC_PHYIF_CTRLSTATUS_LNKMOD (bit 16). Fix this.
> > > 
> > > This appears to be the only use of
> > > GMAC_PHYIF_CTRLSTATUS_LNKMOD_MASK. Maybe it should be removed after
> > > this change?
> > 
> > There is a PCS-refactoring work initiated by Russell, which besides of
> > other things may eventually imply dropping this macro:
> > https://lore.kernel.org/netdev/20240624132802.14238-6-fancer.lancer@gmail.com/
> > So unless it is strongly required I guess there is no much need in
> > respinning this patch or implementing additional one for now.
> 
> Nevertheless, a respin is worth doing with Andrew's suggested change
> because this patch will impact the refactoring work even without that
> change. We might as well have a complete patch for this change.
> 
> (Besides, I've already incorporated Andrew's feedback!)

Ok. I just noted that that the respinning wasn't required due to the
same change implied by another patchset. But since you have already
implemented the change to make the patch more complete, then it's even
better than waiting for our STMMAC PCS discussions over.

-Serge(y)

> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!