netdev - Re: [PATCH net-next v13 14/15] net: stmmac: dwmac-loongson: Add Loongson GNET support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yz2pb6h7dkbz3egpilkadcmqfnejtpphtlgypc2ppwhzhv23vv@d3ipubmg36xt>
Date: Fri, 5 Jul 2024 13:40:08 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: Yanteng Si <siyanteng@...ngson.cn>, andrew@...n.ch, 
	hkallweit1@...il.com, peppe.cavallaro@...com, alexandre.torgue@...s.st.com, 
	joabreu@...opsys.com, Jose.Abreu@...opsys.com, linux@...linux.org.uk, 
	guyinggang@...ngson.cn, netdev@...r.kernel.org, chris.chenfeiyang@...il.com, 
	si.yanteng@...ux.dev
Subject: Re: [PATCH net-next v13 14/15] net: stmmac: dwmac-loongson: Add
 Loongson GNET support

Hi Huacai

On Wed, Jul 03, 2024 at 09:19:59AM +0800, Huacai Chen wrote:
> On Tue, Jul 2, 2024 at 9:43 PM Serge Semin <fancer.lancer@...il.com> wrote:
> > ...
> > On Wed, May 29, 2024 at 06:21:09PM +0800, Yanteng Si wrote:
> > > ...
> > ...
> > > +#define DWMAC_CORE_LS2K2000          0x10    /* Loongson custom IP */
> >
> > Note it's perfectly fine to have a device named after the SoC it's
> > equipped to. For example see the compatible strings defined for the
> > vendor-specific versions of the DW *MAC IP-cores:
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml
> >
> > But if you aren't comfortable with such naming we can change the
> > macro to something like:
> > #define DWMAC_CORE_LOONGSON_MULTI_CH    0x10
> Maybe DWMAC_CORE_LOONGSON_MULTICHAN or DWMAC_CORE_LOONGSON_MULTI_CHAN
> is a little better?
> 

Well, I don't have a strong opinion about that in this case.
Personally I prefer to have the shortest and still readable version.
It decreases the probability of the lines splitting in case of the
long-line statements or highly indented code. From that perspective
something like DWMAC_CORE_LS_MULTI_CH would be even better. But seeing
the driver currently don't have such cases, we can use any of those
name. But it's better to be of such length so the code lines the name
is utilized in wouldn't exceed +80 chars.

-Serge(y)