Message-ID: <8734ooj8vy.fsf@BLaptop.bootlin.com>
Date: Fri, 05 Jul 2024 14:55:29 +0200
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: Josua Mayer <josua@...id-run.com>, Andrew Lunn <andrew@...n.ch>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Richard Cochran <richardcochran@...il.com>
Cc: Yazan Shhady <yazan.shhady@...id-run.com>,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Josua Mayer
 <josua@...id-run.com>, Krzysztof Kozlowski
 <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v7 0/5] arm64: dts: add description for solidrun cn9130
 som and clearfog boards

Josua Mayer <josua@...id-run.com> writes:

> SolidRun CN9130 SoM is a mostly pin-comptible replacement for Armada 388
> SoM used in Clearfog and Clearfog Pro boards.
>
> 1. Add new binding for compatible strings closely matching the original.
>
> 2. Add device-tree includes for SoM and carrier shared design.
>
> 3. Add device-tree for both Clearfog Base and Pro.
>
> While dtbs_check is happy with LED descriptions behind dsa switch,
> functionally they require supporting code by Andrew Lunn:
> https://lore.kernel.org/r/20240401-v6-8-0-net-next-mv88e6xxx-leds-v4-v3-0-221b3fa55f78@lunn.ch
>
> NOTICE IN CASE ANYBODY WANTS TO SELF-UPGRADE:
> CN9130 SoM has a different footprint from Armada 388 SoM.
> Components on the carrier board below the SoM may collide causing
> damage, such as on Clearfog Base.
>
> Signed-off-by: Josua Mayer <josua@...id-run.com>

Seriues applied on mvebu/dt64

Thanks,

Gregory
> ---
> Changes in v7:
> - dropped dt-bindings for usb phy and adc which were picked into their
>   respective trees
> - Link to v6: https://lore.kernel.org/r/20240602-cn9130-som-v6-0-89393e86d4c7@solid-run.com
>
> Changes in v6:
> - add device-tree for cn9132 clearfog and CEX-7 module
> - add dt compatible for tla2021 adc
>   --> I don't plan to submit a driver patch because I can't test it
>   --> might share untested patch
> - add dt property for swapping d+-/d- on cp110 utmi phy
>   --> I plan to submit a driver patch, already prototyped
> - removed duplicate node reference / status=okay for cp0_utmi from
>   cn9131-cf-solidwan.dts
> - rebased on 6.10-rc1
> - Link to v5: https://lore.kernel.org/r/20240509-cn9130-som-v5-0-95493eb5c79d@solid-run.com
>
> Changes in v5:
> - replaced *-gpio properties with preferred *-gpios
>   (Reported-by: robh@...nel.org)
> - removed fixed-regulator regulator-oc-protection-microamp properties
>   This property is intended to set a configurable over-current limit to
>   a particular value. The physical component however is not
>   configurable, remove the property.
> - kept all review tags since the changes were minor, hope that is okay
>   with everybody.
> - Link to v4: https://lore.kernel.org/r/20240502-cn9130-som-v4-0-0a2e2f1c70d8@solid-run.com
>
> Changes in v4:
> - Picked up reviewed-by tags by Andrew Lunn.
> - fixed a typo and changed 3-line comment into single-line comment
>   for clearfog-base/-pro dts, but kept review tags since change was
>   minor.
> - Updated SFP led labels to use "sfp?:colour" without "color" property,
>   to avoid duplicate labels while reflecting they are each dual-colour.
> - Link to v3: https://lore.kernel.org/r/20240414-cn9130-som-v3-0-350a67d44e0a@solid-run.com
>
> Changes in v3:
> - picked up acked-by for dt-bindings
> - skipped acked-by for dts because additional changes were made:
>   - moved legacy netdev aliases to carrier dts
>   - fix status property style errors
>   - add pinctrl for secondary spi chip-select on mikrobus header (& som)
>   - specify spi bus frequency limits for som
> - Added CN9131 SolidWAN board
> - Link to v2: https://lore.kernel.org/r/20240404-cn9130-som-v2-0-3af2229c7d2d@solid-run.com
>
> Changes in v2:
> - rewrote dt bindings dropping unnecessary compatibles
>   (Reported-By: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>)
> - added bindings for two additional boards (cn9131/9132)
>   support planned for the coming weeks, mostly serves
>   illustrational purposes, to understand cn913x variants
> - cf-pro: add description for LEDs behind DSA switch
> - cf-base: add description for LEDs behind PHYs
>   (Reported-By: Andrew Lunn <andrew@...n.ch>)
> - Link to v1: https://lore.kernel.org/r/20240321-cn9130-som-v1-0-711127a409ae@solid-run.com
>
> ---
> Josua Mayer (5):
>       dt-bindings: arm64: marvell: add solidrun cn9130 som based boards
>       dt-bindings: arm64: marvell: add solidrun cn9132 CEX-7 evaluation board
>       arm64: dts: add description for solidrun cn9130 som and clearfog boards
>       arm64: dts: add description for solidrun cn9131 solidwan board
>       arm64: dts: add description for solidrun cn9132 cex7 module and clearfog board
>
>  .../bindings/arm/marvell/armada-7k-8k.yaml         |  18 +
>  arch/arm64/boot/dts/marvell/Makefile               |   4 +
>  arch/arm64/boot/dts/marvell/cn9130-cf-base.dts     | 178 ++++++
>  arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts      | 375 +++++++++++
>  arch/arm64/boot/dts/marvell/cn9130-cf.dtsi         | 197 ++++++
>  arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi     | 160 +++++
>  arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts | 637 ++++++++++++++++++
>  arch/arm64/boot/dts/marvell/cn9132-clearfog.dts    | 673 +++++++++++++++++++
>  arch/arm64/boot/dts/marvell/cn9132-sr-cex7.dtsi    | 712 +++++++++++++++++++++
>  9 files changed, 2954 insertions(+)
> ---
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
> change-id: 20240318-cn9130-som-848e86acb0ac
>
> Sincerely,
> -- 
> Josua Mayer <josua@...id-run.com>

Powered by blists - more mailing lists