netdev - Re: [PATCH net-next v2] act_ct: prepare for stolen verdict coming from conntrack and nat engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240705094222.GC1095183@kernel.org>
Date: Fri, 5 Jul 2024 10:42:22 +0100
From: Simon Horman <horms@...nel.org>
To: Florian Westphal <fw@...len.de>
Cc: netdev@...r.kernel.org, xiyou.wangcong@...il.com, jiri@...nulli.us,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	jhs@...atatu.com
Subject: Re: [PATCH net-next v2] act_ct: prepare for stolen verdict coming
 from conntrack and nat engine

On Thu, Jul 04, 2024 at 01:29:20PM +0200, Florian Westphal wrote:
> At this time, conntrack either returns NF_ACCEPT or NF_DROP.
> To improve debuging it would be nice to be able to replace NF_DROP verdict

nit: debugging

     (I don't think there is a need to repost just because of this)

> with NF_DROP_REASON() helper,
> 
> This helper releases the skb instantly (so drop_monitor can pinpoint
> exact location) and returns NF_STOLEN.
> 
> Prepare call sites to deal with this before introducing such changes
> in conntrack and nat core.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  No changes, v1 errounously targetted 'net' tree.

Reviewed-by: Simon Horman <horms@...nel.org>