[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZpWbUjHna1cE5zHW@mone.local>
Date: Tue, 16 Jul 2024 00:01:28 +0200
From: Patrick Wildt <patrick@...eri.se>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Kalle Valo <kvalo@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Steev Klimaszewski <steev@...i.org>, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1e80100-yoga: add wifi
calibration variant
Am Tue, Jul 16, 2024 at 12:51:53AM +0300 schrieb Dmitry Baryshkov:
> On Mon, Jul 15, 2024 at 09:40:41PM GMT, Patrick Wildt wrote:
> > Describe the bus topology for PCIe domain 4 and add the ath12k
> > calibration variant so that the board file (calibration data) can be
> > loaded.
> >
> > Signed-off-by: Patrick Wildt <patrick@...eri.se>
> > ---
> > .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 9 +++++++++
> > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 ++++++++++
> > 2 files changed, 19 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > index fbff558f5b07..f569f0fbd1fc 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > @@ -635,6 +635,15 @@ &pcie4_phy {
> > status = "okay";
> > };
> >
> > +&pcie4_port0 {
> > + wifi@0 {
> > + compatible = "pci17cb,1107";
> > + reg = <0x10000 0x0 0x0 0x0 0x0>;
> > +
> > + qcom,ath12k-calibration-variant = "LES790";
>
> It doesn't look like it follows the rest of the calibration variants.
>
> Something like "Lenovo_Y7x" or "Lenovo_Yoga7x" sounds more logical.
This is what's both in the DSDT
Device (WLN)
{
[...]
Name (BDFE, "BDF_LES790")
and kvalo's board-2.bin for this machine:
$ strings board-2.bin | grep LES
bus=pci,vendor=17cb,device=1107,subsystem-vendor=17aa,subsystem-device=e0e9,qmi-chip-id=2,qmi-board-id=255,variant=LES790
I don't think we can hand-pick these strings, they come from whoever
decided upon them and fed them into ACPI tables and QC's binaries.
Powered by blists - more mailing lists