netdev - Re: [PATCH net-next] net: axienet: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518b7c0c-54df-403a-bb06-495526e160a9@lunn.ch>
Date: Wed, 17 Jul 2024 22:38:26 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, michal.simek@....com, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	git@....com,
	Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com>
Subject: Re: [PATCH net-next] net: axienet: Fix coding style issues

On Thu, Jul 18, 2024 at 12:24:43AM +0530, Radhey Shyam Pandey wrote:
> From: Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com>
> 
> Replace all occurences of (1<<x) by BIT(x) to get rid of checkpatch.pl
> "CHECK" output "Prefer using the BIT macro".
> 
> It also removes unnecessary ftrace-like logging, add missing blank line
> after declaration and remove unnecessary parentheses around 'ndev->mtu
> <= XAE_JUMBO_MTU' and 'ndev->mtu > XAE_MTU'.

Ideally, this should of been multiple patches. In general, we want a
patch to do one thing, which makes it easier to review.

net-next is closed at the moment due to the merge window. Please
repost in two weeks, once it opens again.

	Andrew