netdev - Re: [PATCH net-next v5 17/25] ovpn: implement keepalive mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c26fc98-1748-4344-bb1c-11d8d47cc3eb@openvpn.net>
Date: Thu, 18 Jul 2024 09:46:00 +0200
From: Antonio Quartulli <antonio@...nvpn.net>
To: Andrew Lunn <andrew@...n.ch>
Cc: Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
 kuba@...nel.org, ryazanov.s.a@...il.com, pabeni@...hat.com,
 edumazet@...gle.com
Subject: Re: [PATCH net-next v5 17/25] ovpn: implement keepalive mechanism

On 18/07/2024 04:01, Andrew Lunn wrote:
>>>> +		if (ovpn_is_keepalive(skb)) {
>>>> +			netdev_dbg(peer->ovpn->dev,
>>>> +				   "ping received from peer %u\n", peer->id);
>>>
>>> That should probably be _ratelimited, but it seems we don't have
>>> _ratelimited variants for the netdev_* helpers.
>>
>> Right.
>> I have used the net_*_ratelimited() variants when needed.
>> Too bad we don't have those.
> 
> If you think netdev_dbg_ratelimited() would be useful, i don't see why
> you cannot add it.
> 
> I just did an search and found something interesting in the history:
> 
> https://lore.kernel.org/all/20190809002941.15341-1-liuhangbin@gmail.com/T/#u
> 
> Maybe limit it to netdev_dbg_ratelimited() to avoid the potential
> abuse DaveM was worried about.

I see what Dave says however...

...along the packet processing routine there are several messages (some 
are err or warn or info) which require ratelimiting.
Otherwise you end up with a gazilion log entries in case of a long 
lasting issue.

Right now I am using net_dbg/warn/err/info_ratelimited(), therefore not 
having a netdev counterpart is not really helping with Dave's argument.

I can try to take on this mission after this patchset is in and see what 
Dave/Jakub think about it.


Regards,


-- 
Antonio Quartulli
OpenVPN Inc.