netdev - Re: [Intel-wired-lan] [PATCH iwl-net] ice: Introduce netif_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <faaf8123-0450-4ddb-ae86-50b8be1385dc@linux.intel.com>
Date: Mon, 22 Jul 2024 18:26:17 +0200
From: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
 Jakub Kicinski <kuba@...nel.org>,
 Alexander Lobakin <aleksander.lobakin@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: Introduce
 netif_device_attach/detach into reset flow

On 22.07.2024 16:35, Paul Menzel wrote:
>> Maybe "Add netif_device_attach/detach" would be the best for this, as 
>> the attaching and detaching doesn't happen only during reset.
> 
> I’d consider it too generic and would mention the place. But if it’s not 
> possible, then it’s not. Maybe:
> 
>> Attach/detach device before starting/stopping queues
>

Okay, will wait for some more feedback from other folks, maybe they'll 
have some input about the naming of the title as well.

>> Once the driver is fully initialized:
>> # echo 1 > /sys/class/net/ens1f0np0/device/reset
>> and then once that is in progress, from another terminal:
>> # ethtool -c ens1f0np0
>>
>> Would you like me to include those in the commit message as well?
> 
> I’d find it helpful, but I am no maintainer.

I will include it in the commit message.

> 
> Kind regards,
> 
> Paul

--Dawid