netdev - Re: [Intel-wired-lan] [PATCH iwl-net] ice: Introduce netif_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <232df828-baa3-4c87-b5f3-c0dae9d98356@molgen.mpg.de>
Date: Mon, 22 Jul 2024 16:35:15 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
Cc: netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
 Jakub Kicinski <kuba@...nel.org>,
 Alexander Lobakin <aleksander.lobakin@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: Introduce
 netif_device_attach/detach into reset flow

Dear Dawid,


Thank you for your quick reply.


Am 22.07.24 um 14:55 schrieb Dawid Osuchowski:
> On 22.07.2024 14:37, Paul Menzel wrote:

>> Introduce … into
>>
>> sounds a little strange to me. Maybe:
>>
>>  > Attach to device in reset flow
>>
>> or just
>>
>>  > Add netif_device_attach/detach
>>
>>  > Serialize …
> 
> Maybe "Add netif_device_attach/detach" would be the best for this, as 
> the attaching and detaching doesn't happen only during reset.

I’d consider it too generic and would mention the place. But if it’s not 
possible, then it’s not. Maybe:

> Attach/detach device before starting/stopping queues

>> Am 22.07.24 um 14:28 schrieb Dawid Osuchowski:
>>> Ethtool callbacks can be executed while reset is in progress and try to
>>> access deleted resources, e.g. getting coalesce settings can result in a
>>> NULL pointer dereference seen below.
>>
>> What command did you execute?
> 
> Once the driver is fully initialized:
> # echo 1 > /sys/class/net/ens1f0np0/device/reset
> and then once that is in progress, from another terminal:
> # ethtool -c ens1f0np0
> 
> Would you like me to include those in the commit message as well?

I’d find it helpful, but I am no maintainer.


Kind regards,

Paul